lucasmaziero / LiquidCrystal_I2C

Library for the LiquidCrystal LCD display connect I2C bus to an ESP8266 or Arduino board
MIT License
20 stars 20 forks source link

Method size_t LiquidCrystal_I2C::write() does not return a value #4

Open grmcdorman opened 2 years ago

grmcdorman commented 2 years ago
inline size_t LiquidCrystal_I2C::write(uint8_t value) {
    send(value, Rs);
}

Missing return value. This is an error and can fail builds if warnings-as-errors is turned on for this issue. I believe this can also cause resets or other undefined behaviour if code tries to use the non-existent return value.

The method signature either needs a return type of void, or the method needs to return a value.