lucasmazza / copy-as-rtf

A package to export highlighted code as RTF
Other
19 stars 14 forks source link

Alt+R in windows doesnt work #12

Closed alanlivio closed 8 years ago

alanlivio commented 9 years ago

The plugin offer a command in Alt+R in windows. But the text is not copied.

anseljh commented 9 years ago

:+1: Good package idea.

jeff-mettel commented 9 years ago

Confirmed that this doesn't appear to be working in Windows.

Tandysony commented 9 years ago

"Alt+R" doesn't work in Windows 7 64bit SP1.

lucasmazza commented 9 years ago

alt+r probably won't work - since the OS X shortcut is cmd+alt+r, ctrl should be cm counterpart on Windows. If it doesn't work, I think we need to add a platform specific mapping but I don't have a windows box around to test this.

Anyone wants to take a look on that and maybe write a PR adding the mapping?

steak3 commented 9 years ago

Debugged in Windows 7 64bit SP1: cmd-alt-r doesn't seem to be triggered in Windows.

In the keymaps, a simple fix could be adding something like this:

'atom-workspace':
  'cmd-alt-r': 'copy-as-rtf:copy' # mac support
  'ctrl-alt-r': 'copy-as-rtf:copy' # windows support

OR if Mac supports CTRL, simply:

'atom-workspace':
  'ctrl-alt-r': 'copy-as-rtf:copy' # mac (?) and windows support

BUT, in Windows, this command is already natively used by Atom to refresh the window. Which makes conflicts. So, what do you think is the best solution?

'atom-workspace':
  'alt-r': 'copy-as-rtf:copy' #or another letter
'atom-workspace':
  'cmd-alt-r': 'copy-as-rtf:copy' 
  'alt-r': 'copy-as-rtf:copy'

I have a preference for the first solution. I can fix it as I have a fork on Windows

aliensyntax commented 9 years ago

Cannot get these key bindings to work on a Linux PC.

steak3 commented 9 years ago

Which key bindings? alt-r should work on Linux I guess

lucasmazza commented 8 years ago

Closed by #17.