lucasmeijer / NiceIO

For when you've had to use System.IO one time too many
MIT License
128 stars 19 forks source link

Changes to make NiceIO compliant with netstd1.6 #13

Closed mrvoorhe closed 7 years ago

mrvoorhe commented 7 years ago

With these few harmless changes, NiceIO becomes compliant with netstandard1.6

I'm not an expert on StringComparison, but based on my understanding of the recommendations here : https://msdn.microsoft.com/en-us/library/dd465121.aspx using Ordinal compare actually sounds like a slight better option than Invariant (which does not exist in netstd1.6)

il2cpp's version of NiceIO needs to be compliant with netstd1.6. In order to do that, we have had these few changes in il2cpp's copy of NiceIO for months. Keeping these only in the il2cpp copy of NiceIO.cs makes keeping NiceIO in sync harder since you can't just copy over the latest NiceIO.cs from github.