search

lucasmerlin / egui_skia

Render egui with skia!
MIT License
57 stars 13 forks source link

Bump to egui 0.24 #13

Open TheZoq2 opened 11 months ago

TheZoq2 commented 11 months ago

This bumps egui to 0.24 which had incompatibilities with the previous version.

egui-sdl2-event is still on on 0.23 or older so the tests or examples don't currently run

lucasmerlin commented 11 months ago

Hi! Thanks for opening the PR! I guess this is blocked on the update of egui-sdl2-event? Maybe you can also open an issue over there?

MCOfficer commented 9 months ago

Seems like egui-sdl2-events is updated to egui 0.24: https://github.com/kaphula/egui-sdl2-event/blob/master/lib/Cargo.toml (but not 0.25)

lucasmerlin commented 9 months ago

I just realized that egui_skia only depends on egui-sdl2-events for the two sdl examples, maybe we could just comment the dependency until it is updated to the most recent version (egui already seems to be updated to 0.26 now), and add a note to the two examples that they currently won't work.

But still, at least the winit integration will need to be updated before we can release an update with a current egui version. I don't use this crate anymore so I can't put the work into updating but I'm happy to review and help so we can get a new version released soon.

TheZoq2 commented 9 months ago

I don't use this crate anymore so I can't put the work into updating but I'm happy to review and help so we can get a new version released soon.

I'm actively using it, but only for the rendering to images for snapshot testing of https://gitlab.com/surfer-project/surfer. I therefore keep my fork up-to-date enough to work for that, but don't really have the time to update the rest of the library.

If you are open to scaling the library back to only the software rendering part, I'd be happy to maintain it.

oosavu commented 4 days ago

Hi! First of all, thank you for this repo! I am planning to use it with the latest safe_skia and egui and i don't need winit and SDL libraries. Just skia+egui. As i understand, master brunch is outdated. Should i use modified sources from TheZoq2:master? This PR is still not merged yet is only because egui-sdl2-events lib? Is it better to use TheZoq2 version in my case?

lucasmerlin commented 4 days ago

Hi @oosavu, I think in your case it's fine to just use the version from @TheZoq2. I don't really care about the sdl things since it was only used in an example but I think at least the winit integration should be upgraded to work, then I could release a new version of the crate.