search

lucasmerlin / hello_egui

A collection of useful crates for egui
https://lucasmerlin.github.io/hello_egui/
MIT License
272 stars 24 forks source link

Improve documentation #4

Closed YgorSouza closed 1 year ago

YgorSouza commented 1 year ago

Hi,

I added some standard items to your crate docs, and fixed most clippy lints. Let me know if I got anything wrong.

You might want to add a CI workflow to check for compiler warnings or failing tests. I don't use GitHub much myself, but you can probably copy the one from egui_dock, since it is very similar to your project.

YgorSouza commented 1 year ago

I also made some improvements to the shift_vec function here if you want to take a look. As far as I can tell it works the same as before. I can make another PR for that or add it to this one if you want.

lucasmerlin commented 1 year ago

I also made some improvements to the shift_vec function here if you want to take a look. As far as I can tell it works the same as before. I can make another PR for that or add it to this one if you want.

Looks good, feel free to make another PR!