feat: Bookmark location model and manager

lucasmontano / openweathermap-ios

Weather, everybody wants to know how it is going to be during the week. Will it be rainy, windy, or sunny? Luckily for us, in the information age, there are open APIs to retrieve information about it.

MIT License

30 stars 11 forks source link

feat: Bookmark location model and manager #13

Open cassiosousa opened 4 years ago

cassiosousa commented 4 years ago

This pull request includes

It's adding testing module to project.
The structure of bookmark location model and manager.

Feat: #13

henrique-morbin-ifood commented 4 years ago

Do you want partial reviews or do you prefer we wait until you say it is ready for review?

cassiosousa commented 4 years ago

Thank you Henrique, I don't have see your comment, but now is available to full review.

cassiosousa commented 4 years ago

Henrique,

I started to work at the view of bookmarkLocation. Those corners are giving work :), but it will be rewarding.

henrique-morbin-ifood commented 4 years ago

@cassiosousa give a better PR title please.

henrique-morbin-ifood commented 4 years ago

@cassiosousa what did you mean with: Full backend to Add button ?

cassiosousa commented 4 years ago

@henrique-morbin-ifood

give a better PR title please. what did you mean with: Full backend to Add button ?

I updated the two things.

henrique-morbin-ifood commented 4 years ago

Please, read this comment: https://github.com/lucasmontano/openweathermap-ios/pull/13#discussion_r416745061

cassiosousa commented 4 years ago

Please, read this comment: #13 (comment)

✅ @henrique-morbin-ifood , I go todo that change, it was suggest in the next PR. I also follow this guy hackingwithswift 🙂

henrique-morbin-ifood commented 4 years ago

@lucasmontano LGTM