search

lucasmontano / openweathermap-ios

Weather, everybody wants to know how it is going to be during the week. Will it be rainy, windy, or sunny? Luckily for us, in the information age, there are open APIs to retrieve information about it.
MIT License
30 stars 11 forks source link

Created view controller class Details #3

Closed felipebweber closed 4 years ago

felipebweber commented 4 years ago

Created view controller class Details and renamed ViewController class to MapViewController.

henrique-morbin-ifood commented 4 years ago

@felipebweber What is the purpose of your PR?

henrique-morbin-ifood commented 4 years ago

You could send small and valuable increments instead of empty view controllers.

felipebweber commented 4 years ago

The idea was to do this PR and continue the development. But I did a PR wrong without the functionality. It was my mistake. How to cancel a PR? So that the next PR with an implementation is done. I have some features in the test code but I didn't put it in the main code because I want to do a PR later. Sorry, I'm new to PR and collaborating with code. My undergraduate and master's degree I did a good part of the implementation and then did the commit. I know I'm not sorry. I am here to help and learn from the teachings and opinions of the most experienced. They are very welcome and I listen and improve. My greatest intention is to help and thus have a closer contact than would be a development in a company.

felipebweber commented 4 years ago

How to cancel the PR? I want to submit another one with some implementations.

lucasmontano commented 4 years ago

I'm closing the PR for you :)