Closed powilliam closed 4 years ago
Nice work here @powilliam ! is this PR ready to be merged? Also, can you add to the ReadMe how to run the tests? Thanks!
Thanks :smile:! I have updated the Readme and now it's ready to merge
Sorry, my Readme was outdated since #13 was merged. It's all right now
Motivations
Changes
ChatterService
to be responsible for the future communication with the extension. Now it just have one method which isgetViewers
that returns an array with all persons connected to the chat;src/app.ts
to create the express instance and export it as default. By this way in the future we can do e2e tests withsupertest
without listening to a port on localhost;src/server.ts
to just listen the port and be the entry point for the application. When implementing theSocket.IO
there will be where we'll create a http server fromhttp.createServer
and use it to implements theSocket.IO
;