search

lucasmontano / twitch

[EBS] Channel's Top Visitors
https://www.twitch.tv/lucas_montano
119 stars 15 forks source link

feat(chat-service): Bots on the viewers list? #30

Closed omurilo closed 4 years ago

omurilo commented 4 years ago

Add feature to remove bots from viewers list to close #29

omurilo commented 4 years ago

Hey, i liked how you solved this compared to the first implementation. It's perfect. Can you also write new ones or refactor those tests please?

Because removeBots it is a private method i don't think on a test for him, but i've refactor the existing method to add a test to verify if this.bots is greather than or equal 0.

powilliam commented 4 years ago

There's no problems. Great job here!

EduardoAraujoB commented 4 years ago

do you know if this PR will have conflicts with the PR #33 ?

nataneb32 commented 4 years ago

Nope. It doesn't.

nataneb32 commented 4 years ago

Actually the only conflict is in the .env.example. This PR has a better version than mine. When merge it's the only thing to be cautious about.