lucasmotta / dploy

⛔️ currently unmaintained ⛔️
http://lucasmotta.github.io/dploy/
MIT License
988 stars 89 forks source link

If FTP Connection fails, there should be a non-zero return #98

Open coreyog opened 8 years ago

coreyog commented 8 years ago

I'm working to incorporate dploy in the new Bitbucket Pipelines. For whatever reason the FTP connection is failing. Bitbucket Pipelines seems to think everything went fine because dploy seems to be emitting an exit code of 0. For continuous integration, any process failure should result in a non-zero exit code.

coreyog commented 8 years ago

Output from bitbucket pipelines (Note that $FTP_PASSWORD is a bitbucket pipeline that is successfully set up):

+ echo $FTP_PASSWORD | npm run deploy
npm info it worked if it ends with ok
npm info using npm@3.8.6
npm info using node@v5.11.0
npm info lifecycle material-pokedex@1.0.0~predeploy: material-pokedex@1.0.0

npm info lifecycle material-pokedex@1.0.0~deploy: material-pokedex@1.0.0

> material-pokedex@1.0.0 deploy /opt/atlassian/bitbucketci/agent/build
> dploy

– Enter the password for ftp.materialpokedex.com: 

Connecting to live...
Connection failed.
Connection failed.

npm info lifecycle material-pokedex@1.0.0~postdeploy: material-pokedex@1.0.0
npm info ok 

What was ok about this deploy?