search

lucasnevespereira / resumme-builder

Resume builder in Golang using json data and html templates
MIT License
12 stars 5 forks source link

Icons not rendered in stackoverflow template #10

Closed francois07 closed 2 weeks ago

francois07 commented 1 month ago

When using the stackoverflow template, FontAwesome icons are not rendered in the output .pdf file. They are rendered properly in the .html output and when printing this .html file to pdf, they are properly rendered. This bug does not occur when rendering with the oldman template which uses FontAwesome icons too

Steps to reproduce

  1. In the resume.json file, specify any field that the stackoverflow template adds icons to such as basics.email
  2. Run resumme-builder in local mode
lucasnevespereira commented 1 month ago

Hello @francois07 I've just tried to generate the stackoverflow template with the example.resume.json file and icons seem to be working.

Screenshot 2024-07-09 at 22 02 32

I am running this on macOS, by the way. Do you still have the issue ?

francois07 commented 1 month ago

Hello @lucasnevespereira. Yes, I still have this issue. I tested it on Windows and Linux. This is really puzzling to me because even when importing FontAwesome icons exactly the same way as the oldman theme, this still happens.

image

lucasnevespereira commented 1 month ago

@francois07 the main difference I see between template oldman and stackoverflow regarding the icons is the way we import fontawesome

oldman

...
<script src="https://kit.fontawesome.com/990c3c315f.js" crossorigin="anonymous"></script>

stackoverflow

...
    <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.4.2/css/all.min.css" integrity="sha512-z3gLpd7yknf1YoNbCzqRKc4qyor8gaKU1qmn+CShxbuBusANI9QpRohGBreCFkKxLhei6S9CQXFEbbKuqLg0DA==" crossorigin="anonymous" referrerpolicy="no-referrer" />

Have you tried to import it the way oldman does ?

francois07 commented 2 weeks ago

Hey @lucasnevespereira, sorry for the delayed answer. Yes, I've tried to import fontawesome the exact same way as oldman and still had the same issue. Weirdly enough, I am not having this issue anymore. This might have been a network issue where fontawesome could not be imported in time before the pdf is generated, this is a wild guess though lol

lucasnevespereira commented 2 weeks ago

Hello @francois07, alright then! If everything seems to work on your end, I'll close this issue