search

lucasnfe / puct-music-emotion

14 stars 1 forks source link

generate_mcts.py emotion range error? #2

Open Chenfei-Kang opened 1 year ago

Chenfei-Kang commented 1 year ago

Emotion range in [0,1,2,3] in "music emotion classifier", but given [1,2,3,4] in "args" ? Maybe we should pass "opt.emotion - 1" instead of "opt.emotion" to function "generate"? as show below: https://github.com/lucasnfe/puct-music-emotion/blob/abfc4ec4e37cc28b46574f09a1f4e182ea54131c/workspace/generate_mcts.py#L142

ChenyuGAO-CS commented 1 year ago

I also noticed this problem. If I set "--emotion 4", there will be an "out of classifier's range" error.

Chenfei-Kang commented 1 year ago

I also noticed this problem. If I set "--emotion 4", there will be an "out of classifier's range" error.

Yes, we should pass "opt.emotion-1" instead of "opt.emotion". Another question is: The inference time of "puct" I tested is very long, it takes about 10 hours to generate a sample. Have you tested the generation speed？This is my e-mail: 1132048823@qq.com