search

lucaspbordignon / rn-apple-healthkit

A React Native package for interacting with Apple HealthKit
https://www.npmjs.com/package/react-native-health
MIT License
521 stars 297 forks source link

Is this project abandonned? #179

Open olegfeferman opened 4 years ago

olegfeferman commented 4 years ago

Hi everyone,

I see that last release was half a year ago. We wanted to use rn-apple-healthkit in our application but there are few fixes that needs to be done. We thought to fixt it and then submit a PR but then I've seen that there are 32 unmerged PRs (we even found fixes for some of the issues we're having among them). I tried to reach @terrillo but with no luck. Are there other contributors who can potentially review and merge PRs and release an updated version? What is the right way to proceed? Is there a way to donate to the project so issues we are interested in are fixed?

I don't really want to fork the project and build a new npm under a different name or is it an only option?

Thanks!

IceDev-xyz commented 4 years ago

It's fair to say the project is abandoned.

For the last couple of years, some contributors tried to save the repo but ended up leaving.

The owner came back for a brief period of time. Unfortunately, couple of releases broke more things that fixing bugs. I think most of us, have already fork a stable enough version and move forward on our own. Some have published their forks as new NPM, haven't seen one to become the new go-to.

olegfeferman commented 4 years ago

@IceDev-xyz , thanks for taking time to explain everything!

When you mention "stable enough version" - which version do you mean?

IceDev-xyz commented 4 years ago

I forked v0.65. Was stable for what I needed (overall fitness tracking) and kept working on my own.

olegfeferman commented 4 years ago

This one: https://github.com/IceDev-xyz/rn-apple-healthkit ? - looks empty. In any case thanks, I will look into 0.65

IceDev-xyz commented 4 years ago

... yeah, I ended up working on a private version. A lot of cut-corners I'm not proud of.

olegfeferman commented 4 years ago

Got it. I feel we will go same way... 😄

stevelizcano commented 4 years ago

I'll look into taking up the baton, give me a few days as I really need a package like this for long-term

JulianKingman commented 4 years ago

I decided to integrate HK directly into my app, as I ran into performance issues with large amounts of data going over the bridge, and I needed background sync functionality.

olegfeferman commented 4 years ago

@JulianKingman, sorry for a stupid question but how is it possible to integrate it "directly" into React Native app. Or did you switch to another technology?

alfonsosn commented 4 years ago

@olegfeferman I think @JulianKingman means that he is interfacing with Healthkit directly via RN NativeModules.

schumannd commented 4 years ago

@stevelizcano Have you thought about it? I think first we would need a new main fork. Maybe even get the original owner to link to an "official" continuation of the project.

lucaspbordignon commented 4 years ago

@schumannd @stevelizcano I would love to take the lead into this direction too, as I'm going to rely on this library for the long-term. I tried getting in touch with the project owner but I didn't get an answer too

I created a new NPM package to facilitate the development process and also a new repository.

I'm planning in the next few weeks to clean up a few of the documentation (and add proper credits to the original authors) and review a few of the open PRs in this repository, so we can have a central package to work on. Would love to have your help, in case you guys are interested :)

devranerogul commented 4 years ago

Nice to hear that since I am also planning to work with this library on a long term project. Also good decision to review PRs and merge them, I have seen some nice improvements there.. 👍

lucaspbordignon commented 4 years ago

@devranerogul That's great to hear! Feel free to give any advice there too and contribute if you want, would definitively love to hear your inputs for the project

terrillo commented 4 years ago

Hey everyone, I'm looking to give this project to someone else. I'm no longer consistently working on React Native. If you're interested send me an email at healthkit@terrillo.com.

@IceDev-xyz @lucaspbordignon @devranerogul

kenjichanhkg commented 4 years ago

Oh, I just saw this after days I opened a ticket and waiting for some helps: https://github.com/terrillo/rn-apple-healthkit/issues/197

I really need to have health kit in my project, really really need to get data sync with my garmin watch.

I'll try v0.65, see if I have any luck getting any demo working.

IceDev-xyz commented 4 years ago

I'm willing to take the project, I use my own version of this repo (forked from 0.6.5 and kept working on it).

As I use it for my own apps, the focus is on fitness (exercise, steps, activity) more than nutrition, mindfulness and others. But I'll be happy if others contribute on those areas.

I'm thinking of creating a new ReadMe and DemoApp with the functions I focus on, leaving others (ej. getLatestLeanBodyMass) as legacy code.

@terrillo you've got mail.

lucaspbordignon commented 4 years ago

Hey @IceDev-xyz!

That's great to hear. I've also created a new fork and started to add a few of the functions that you've mentioned (as the improved readme and have a ticket for the demo app)

It's hosted here, would be very happy in case you want to join the repository as one of the core contributors for it

I'm not sure which changes and additions have you made at yours, would love to hear from you so we can join forces on this one!

IceDev-xyz commented 4 years ago

@lucaspbordignon

It would make sense to only have 1 repo, and yours looks active, I'll compare both forks and will send some PR in order to match repos.

I'll keep mine alive just in case, but will not publish it on NPM.

What version of this repo did you fork?

lucaspbordignon commented 4 years ago

@IceDev-xyz

For the fork, I've actually made a fork from another one, from nutrisense, as they had a few methods that weren't set in the original repo

I've also added a few of the most recent changes made in this repo on top of that

TowhidKashem commented 4 years ago

@lucaspbordignon @IceDev-xyz Just commenting to say thank you for picking this up! Looking forward to using it for mindful minutes 🙏

kenjichanhkg commented 4 years ago

@lucaspbordignon @IceDev-xyz I'd like to ask a question here. Which forked version allow me to sync/get workout route data, like GPS tracks and heart-rate data? Because I've been looking around and don't find what I need, or maybe I've missed something.

IceDev-xyz commented 4 years ago

My fork doesn't support GPS tracks or Heart-rate data.

And I'm pretty sure you can't get workout data with heart-rate, at least this was true couple of years ago when I tried it, the solution is to get the workout data, and then query heart-rate for the start + end timeframe of the workout.

Also, I could be wrong, but pretty sure works the same way for GPS.

https://developer.apple.com/documentation/healthkit/hkworkout/1615212-workoutwithactivitytype?language=objc https://developer.apple.com/documentation/healthkit/hkworkout/workout_metadata_keys?language=objc

kenjichanhkg commented 4 years ago

@IceDev-xyz I'm trying to write some code to get all the workouts + gps & heart-rate data. But my code doesn't return all the workouts that I did, and I'm struggling about what's the difference of HKSeriesType.workoutRoute() and HKSeriesType.workoutType()

image

jahead commented 3 years ago

Hey if this abandoned and the project has moved on to a repo, could we update this repo's README with the repo we should be focusing on?