search

lucaspiller / twerl

Erlang client for the Twitter Streaming API
MIT License
27 stars 13 forks source link

Many improvements #5

Open arjan opened 10 years ago

arjan commented 10 years ago

This branch supports OAuth, reconnecting behaviour, configurability of the Endpoint URL (both GET and POST).

Furthermore it prefixes the modules with twerl_ to comply with common Erlang coding guidelines.

arjan commented 10 years ago

Hmm, no idea how your own commits became part of this PR..

lucaspiller commented 10 years ago

Awesome, thanks! I'll take a look over the next couple of days - bug me if I haven't in a week!

On Wed, Feb 12, 2014 at 12:21 am, Arjan Scherpenisse notifications@github.com="mailto:notifications@github.com"> wrote:

Hmm, no idea how your own commits became part of this PR..

— Reply to this email directly or view it on GitHub.

arjan commented 10 years ago

@lucaspiller here's me bugging you ;)

lucaspiller commented 10 years ago

Haha thanks :D I'll try and remember to look at it this week.

If you have a chance would you mind figuring out why Travis is broken? (I think it's using the wrong version of Erlang or something)

arjan commented 10 years ago

Yeah, sorry about that :p I'll check it out..

arjan commented 10 years ago

seems the espec binary that is in the repo should be built against R14.. weird, because I did not touch that at all.

lucaspiller commented 10 years ago

Ok I had a quick look this morning (I also fixed the espec issues myself in master). I want to add a few more tests and examples before I merge this, so I'll take a look at that after work.

arjan commented 10 years ago

I see you're integrating part of this, cool :) Sorry it's such a big branch.

arjan commented 10 years ago

This last commit is quite essential -- otherwise the httpc connection is kept open after the twerl_stream process terminates. This causes issues if you want to do a new streaming connection (e.g. changed filtering parameters); the new connection to Twitter will be established but no tweets will arrive.