NetcodeClientTransport.client_id() still returns u64

lucaspoffo / renet

Server/Client network library for multiplayer games with authentication and connection management made with Rust

Apache License 2.0

662 stars 68 forks source link

NetcodeClientTransport.client_id() still returns u64 #108

Closed HeartofPhos closed 10 months ago

HeartofPhos commented 1 year ago

Might have been missed in this PR https://github.com/lucaspoffo/renet/pull/103

ActuallyHappening commented 10 months ago

Yes I was confused at this, glad other people noticed. Will make PR

Well, the question is where the ClientId type should live. renetcode has very few dependencies, but renet has a dependency on renetcode. Hence, renetcode which exports the NetcodeClientTransport type cannot depend on renet. Maybe we split that type into renet_core?

lucaspoffo commented 10 months ago

Fixed by 94903555b1a51d1b5739bd0e44224f4dc3534807

I decided to just use ClientId and not split the type to a new crate, seemed a bit too much just for this simple case.