search

lucaspulliese / vue-cool-lightbox

Vue.js lightbox inspired by fancybox.
https://vue-cool-lightbox.lucaspulliese.com
341 stars 54 forks source link

video url's don't work with google storage --fix in comments #48

Closed BetKingIO closed 4 years ago

BetKingIO commented 4 years ago

Google storage and other cloud providers will add an access key on to the url after the file extension. These url's don't work in cool lightbox.

If you modify the checkIsMp4 and getVideoExt to check if the url contains a video extension instead of checking if it ends then it works.

I didn't submit a pull request in case that breaks any other functionality but these changes work in my project.

lucaspulliese commented 4 years ago

Hi @BetKingIO!

Yes, you are right, I will be working on it.

lucaspulliese commented 4 years ago

Hi @BetKingIO!

Sorry, I know it's been a while, but in the latest version, 2.4.2, this issue is fixed.

If you can, please close the issue if everything is ok.

BetKingIO commented 4 years ago

Thanks for the update.