search

lucaspulliese / vue-cool-lightbox

Vue.js lightbox inspired by fancybox.
https://vue-cool-lightbox.lucaspulliese.com
341 stars 54 forks source link

Video is still playing in background after clicking Next or Previous #61

Closed SothormSok closed 3 years ago

SothormSok commented 3 years ago

How to reproduce

  1. Go to the official example https://vue-cool-lightbox.lucaspulliese.com/#example-video
  2. Open the first video
  3. Click Play
  4. Click to next video

Now you can still hear the previous video is still playing in the background and if you click play in the current video, it will play overlapping the previous one. A free remix :)

Expected result When clicking the Next or Previous button, the current playing video will stop and move on to the other video in the item list.

lucaspulliese commented 3 years ago

Hi @StormWitcher!

First of all, thanks for the star :).

Yup, you are right, I will check that issue today, thanks!

SothormSok commented 3 years ago

Thank you for the quick fix. Highly appreciate. I confirmed the issue is solved in the latest version 2.6.6.

lucaspulliese commented 3 years ago

You're welcome!

I didn't tell you about to test the component because I saw a small bug on Vimeo videos, but it's not something that breaks the component funcionality, but I will let you know when it's fixed.

lucaspulliese commented 3 years ago

Hi again @StormWitcher.

I fixed that issue on Vimeo videos on version 2.6.7. Thanks for the enhancement.

Cheers!

SothormSok commented 3 years ago

Well done!

Thanks for the fixes and I love the component.