lucasr / smoothie

[DEPRECATED] Easy async loading for Android's ListView/GridView
985 stars 163 forks source link

Multi-part items not loading #14

Open blaztriglav opened 11 years ago

blaztriglav commented 11 years ago

We have a 2-part item in our ListView, a big image with a small profile picture.

Some big images (first priority) don't load when the user is looking at them. Edit: What I mean here, if you scroll slowly, the off-screen images load properly, but if an image is not loaded, and the user has that ListView item visible on the screen, it never loads.

I enabled logging in Smoothie, and this is what I get on those items:

"Item should not load, bailing: ..." (line 243 in ItemLoader)

But they are null/set to placeholder, and should load. If I switch to single-item, the big images load properly.

The current hack is commenting out the entire block starting with: if (!itemState.shouldLoadItem) {...}

Everything works as it should then, but I'm guessing there's a good reason that block is there, and it's definitely not the proper way :).