lucasr / twoway-view

[DEPRECATED] RecyclerView made simple
5.23k stars 1.02k forks source link

Back press issue - not able to move back using android hardware back button. #265

Open virendragupta30 opened 8 years ago

virendragupta30 commented 8 years ago

Hi.. Thanks for providing nice library. I am using https://github.com/lucasr/twoway-view/tree/twowayview-0-1. So because of onKeyDown, onKeyMultiple, onKeyUp event not able to move back. first we need to click somewhere in screen then only able to move back. so reason in overridden method onKeyDown, onKeyMultiple, onKeyUp in TwoWayView.java. If we comment these methods then working fine. So please explain me why we meed to override onKeyDown, onKeyMultiple, onKeyUp which disturb android default behavior.
So next release please remove below method - @Override public boolean onKeyDown(int keyCode, KeyEvent event) { return handleKeyEvent(keyCode, 1, event); }

@Override
public boolean onKeyMultiple(int keyCode, int repeatCount, KeyEvent event) {
    return handleKeyEvent(keyCode, repeatCount, event);
}

@Override
public boolean onKeyUp(int keyCode, KeyEvent event) {
    return handleKeyEvent(keyCode, 1, event);
}

This is on TwoWayView.java line no. 1766 to 1779.

Please reply as soon as possible.

Thanks Virendra