search

lucasrla / remarks

Extract annotations (highlights and scribbles) from PDF, EPUB, and notebooks marked with reMarkable tablets. Export to Markdown, PDF, PNG, SVG
GNU General Public License v3.0
353 stars 20 forks source link

Fixing for the new highlights in rM v2.8 and 2.11. Refs #37 #39 #46 #47 #38

Closed folofjc closed 2 years ago

folofjc commented 3 years ago

My attempt to fix #37. I wrote a lot of comments so that you could see what I was doing. Feel free to re-factor, etc.

I tested it locally and it works great! I tested with the "old" annotations from pens as well as highlighter that did not get "modified". (i.e. I highlighted in the margins, etc, where there was no text).

folofjc commented 2 years ago

I just pushed again to my master with the fixes for #39. I think you can still use the same PR, right?

folofjc commented 2 years ago

Added support for #46 and #47

lucasrla commented 2 years ago

@folofjc, thank you so much for taking the time to submit all these improvements. I'll resolve the many conflicts and merge them during the weekend.

Meanwhile, you probably want to take a look at the various changes that I've just pushed.

Thanks again!

lucasrla commented 2 years ago

Your PR is now merged.

I left the highlighting parts out of the merge (given that I had followed a different path to support smart highlights). I also tweaked a bit of flags names / logic.

Thanks again!

folofjc commented 2 years ago

Okay, great, thanks for incorporating all this! I will do a pull into mine, and it should bring in all the changes.