Change default page offset to 1

lucasrla / remarks

Extract annotations (highlights and scribbles) from PDF, EPUB, and notebooks marked with reMarkable tablets. Export to Markdown, PDF, PNG, SVG

GNU General Public License v3.0

353 stars 20 forks source link

Change default page offset to 1 #60

Open opal06 opened 1 year ago

opal06 commented 1 year ago

I think that while 0 seems the logical default offset from a programmer's perspective, 1 would actually be a better default as it would fit the average document pagination better. I can make a pull request, but as it's not a big change I wanted to bring it up here first.

Thanks for all the great work, sorry to bother you again!

lucasrla commented 1 year ago

You're right. It pains me a bit to change a flag's default value (due to backwards compatibility) but having it as 1 is just better long term.

Happy to merge your PR.

Thanks!

opal06 commented 1 year ago

@lucasrla I see the argument for backwards compatibility, but if someone really depends on the offset being 0, they should still be able to get that behaviour by setting the flag to 0 on program execution, right?