search

lucasrowe / spoiled

A Chrome extension that blocks content using any keywords a user specifies.
GNU General Public License v2.0
10 stars 5 forks source link

Modernization of the javascript syntax in content_script.js #36

Closed adamgauthier closed 6 years ago

adamgauthier commented 6 years ago

I stumbled upon this project when trying not to get spoiled on Star Wars - The Last Jedi. Surprisingly, this seemed to be the only GNU-licensed project I could find, a particularity I find important for an app that can potentially read everything on every website you visit.

There are several issues with this extension, notably performance, which I'd like to revisit in the future, but for a start I wanted to update the code base to reflect more "modern" and standard syntax practices. Everything seemed to work fine, but if something's wrong, please tell me and I will add the necessary changes.

adamgauthier commented 6 years ago

Hey Lucas, I think linting is a great idea, especially if we can do it as a per-project standard. A good place to start is ESLint, it can be configured in many different ways, but just using the recommended ruleset is already a big step up for most code bases.