search

lucassabreu / comment-coverage-clover

Github Action that automatically adds a comment with a summary of coverage reports (clover)
https://github.com/marketplace/actions/coverage-report-as-comment-clover
16 stars 4 forks source link

Exits with `0` exit code and without debug logging to indicate possible issue when no token is available in env #43

Closed ermik closed 1 year ago

ermik commented 1 year ago

The token usage or required scopes are undocumented https://github.com/lucassabreu/comment-coverage-clover/blob/ec666df65249f2ba5d3c2b3654a85e2912771ec1/src/index.ts#L19

and the returns are not logging anything https://github.com/lucassabreu/comment-coverage-clover/blob/ec666df65249f2ba5d3c2b3654a85e2912771ec1/src/index.ts#L195-L196

lucassabreu commented 1 year ago

hi, i will try to find the required scopes, but the ideia was to use the one created by gh actions by default.

about the zero-exits, i will add some logs for that, and maybe a non-zero exit.

lucassabreu commented 1 year ago

hi @ermik i added to the readme the scope, it needs repo. but is not required, the default token created by github should sufice.

Captura de tela de 2023-10-19 10-54-07

ermik commented 1 year ago

Hey @lucassabreu - appreciate the response. I'm gonna think of what else this can be expanded into. I'm definitely hitting an edge case where nothing is posted even though there's a clover file and a valid token... I think more debug output would be a general point of improvement.

lucassabreu commented 1 year ago

if any error happens it will be shown in the logs, github actions ensures that.

could you post the workflow and workflow log @ermik ?