search

lucastheis / cmt

Fast CPU implementations of several conditional probabilistic models
http://lucastheis.github.io/cmt/
MIT License
36 stars 14 forks source link

Fix issue 14: "Test failure on 0.5.0 (due to missing import)" #18

Closed jakirkham closed 7 years ago

jakirkham commented 8 years ago

Fixes https://github.com/lucastheis/cmt/issues/14

Fix import so that it comes from PIL using a relative import.

lucastheis commented 8 years ago

Thanks jakirkham, this is great. But it looks like your changes are based on the master branch and not the develop branch? The master branch is a bit outdated (totally my fault). For example the import of Image was fixed in a5d2a33b4. Can you base your changes on the develop branch (if they are still necessary)? I will then merge them and create a new release for the master branch.

jakirkham commented 8 years ago

But it looks like your changes are based on the master branch and not the develop branch?

Yeah, it made it easier when initially submitting the patches.

Can you base your changes on the develop branch (if they are still necessary)?

That's totally reasonable and it's my bad for not doing that already. Sure I'll go through and rebase these tomorrow.

I will then merge them and create a new release for the master branch.

That sounds great.

It would be nice if we could figure out what these test failures are caused by. Some seem like they could be kind of minor. Others I am just not clear on.

jakirkham commented 7 years ago

This is unnecessary as of 0.6.0. So am closing.