search

lucastheis / cmt

Fast CPU implementations of several conditional probabilistic models
http://lucastheis.github.io/cmt/
MIT License
36 stars 14 forks source link

Add `-stdlib=libc++` when `CXX` is unspecified #27

Closed jakirkham closed 7 years ago

jakirkham commented 7 years ago

Fixes https://github.com/lucastheis/cmt/issues/25

This argument is not permissible with gcc. Also if a custom compiler like icc or a non-system provided copy of clang is used, this flag will also not work. In other words, only with the macOS provided clang can we safely add the -stdlib=libc++ flag. If users are changing the compiler to one that for some reason can take this flag, they can just as well set it themselves. Hence we only set when CXX is not specified.

FlorianFranzen commented 7 years ago

Thank you for this pull request. Can you cleanly rebase it against the develop branch, so there is only your commit in it?

jakirkham commented 7 years ago

Sure, would definitely appreciate your review of the other PRs here as well.

jakirkham commented 7 years ago

Rebased.

lucastheis commented 7 years ago

Thanks!