Closed KNG-Scherezade closed 6 years ago
A few other comments:
<Math.h>
header that isn't found on my system. Did you mean <cmath>
?
SEED8
Process finished with exit code 136 (interrupted by signal 8: SIGFPE)
3. I got a few compile warnings, which may or may not be related to the runtime crash. Could you fix those?
Thanks!
@KNG-Scherezade The updates look awesome. I saw you thumbs-upped my comment about the override methods. Do you think you'll update this, or do you prefer we move on?
Note that the runtime error I'm getting (Process finished with exit code 136 (interrupted by signal 8: SIGFPE)
) is likely due to either division by zero or floating point overflow/underflow.
Here's where the program is going south for me
Modulo r1, which is 0, is probably the issue (my compiler probably has a different random number generator than yours)
Put in a check r1 = floor(r1) == 0 ? 1:r1;
Alright, I'm going to do more const type&
, line spacing, comment removal and function->header stuff. Going to then convert a few more files from .hpp to .hpp&.cpp.
Probably will be my goal for today to get this looking neat.
It might be worth it to work on generation performance later (beyond just the basic const type&
stuff) but not before this bit is merged.
:birthday: :man_dancing: :tada:
Ez.
Will probably have to consider doing some sort of checking on A and B for clipping with branches or the ground.
ABC also stands for the different versions I worked on and all contain different bugs that make them unique. Because of this A is a class divided into neat sections, B is kind of neat, C is one giant header. Will look into making them more presentable when textures are applied.
Frame rate at sonic speeds is 'decent'. Drops what seems like 3 frames when generating lots of things which is apparent when going quickly. Certain items are more greedy than others.
Nothing else modified from your work.