lucaswerkmeister / ACDC

gadget for Wikimedia Commons to add a collection of statements to a set of files
https://commons.wikimedia.org/wiki/Special:MyLanguage/Help:Gadget-ACDC
2 stars 0 forks source link

Make AC/DC batches undo-able with EditGroups on Commons? #15

Closed trnstlntk closed 2 years ago

trnstlntk commented 2 years ago

Would it be possible to make AC/DC batches undo-able with EditGroups on Wikimedia Commons? I see that you apparently already made it work for QuickCategories :-)

lucaswerkmeister commented 2 years ago

Thanks! I think someone suggested this back before EditGroups for Commons existed, and then I didn’t realize that it could be added to AC/DC when Commons EditGroups eventually came around.

I’m not sure how exactly to handle it, though. I think I have two questions:

trnstlntk commented 2 years ago

Thanks for following up on this, Lucas :-)

My two cents:

  1. Generating an edit group for edits affecting ≥ 10 files sounds great. Manually undo-ing edits to more than 10 files begins to get annoying.
  2. I personally would not prompt the user to create edit summaries. IMO one of AC/DC's strengths is its speed and simplicity. Providing the user with an additional prompt would indeed be a bit disruptive, I think.
lucaswerkmeister commented 2 years ago

Alright, then let’s go with that for now and see if anyone asks for more control after announcing it :)

lucaswerkmeister commented 2 years ago

Alright, it’s deployed to Commons now. Can you see if it works? (It can’t be tested on Test or Beta Commons, and I don’t think I have a real set of ≥10 AC/DC edits to make at the moment.)

lucaswerkmeister commented 2 years ago

Had to add a small fix but now it seems to be working :) https://editgroups-commons.toolforge.org/b/CB/cccf749b6ad9/