search

lucaswerkmeister / ACDC

gadget for Wikimedia Commons to add a collection of statements to a set of files
https://commons.wikimedia.org/wiki/Special:MyLanguage/Help:Gadget-ACDC
2 stars 0 forks source link

Update for ResourceLoader module changes #4

Closed lucaswerkmeister closed 4 years ago

lucaswerkmeister commented 5 years ago

The wikibase.datamodel.* and wikibase.serialization.* modules were merged into one (each), so we should import them differently. (Currently, the old modules are still available in production, but already removed in beta, where this was noticed by the browser tests.)

To make testing in both environments simpler, I added a commented-out alternative base URL to wdio.conf.js and split .mw_credentials into .mw_credentials_beta and .mw_credentials_test, to be used like this:

(. .mw_credentials_beta && make check)
(. .mw_credentials_test && make check)

Depending on which line in wdio.conf.js is currently active.

(wikibase.util.)ClaimGuidGenerator is also prepared for new-style imports (as in, assigned to a top-level variable instead of directly accessing it in wikibase.util where it’s used), though that module is still not exported that way yet.

@Ladsgroup is this the right way to use the new modules? (Well, aside from the fact that they probably shouldn’t be used at all, since they’re not stable interfaces.)

lucaswerkmeister commented 5 years ago

Huh, one of the Travis builds failed. I think this might be because they were both running at the same time and concurrently edited the same test file?

lucaswerkmeister commented 5 years ago

Yup, it worked after a restart :/ probably not worth investing time in, tbh, I don’t expect many PRs or other concurrent builds.

lucaswerkmeister commented 4 years ago

Deployed, thanks for the review!