lucav76 / CarND-Capstone

Fork of the Udacity project to complete the System Integration task, for the "total-recall-dryvers"
3 stars 2 forks source link

Ta/waypoint7 #6

Closed Krishtof-Korda closed 6 years ago

Krishtof-Korda commented 6 years ago

@TimSoft77 , please confirm and merge this if you have no other major additions right now. Small tweaks can be added after merge in master.

jocmom commented 6 years ago

There is an issue when circling through the whole track, at some point the next traffic light index is smaller than the closest point and the car stops moving. Line 76 may cause this behavior:

76: if self.tl_index > closest_point:

TimSoft77 commented 6 years ago

Could the car have reached the end of the path? Per the decelerate() method in waypoint_loader.py (lines 63-72, called at line 57), the car is supposed to complete a series of waypoints once and then stop - not loop forever.

Please let me know if the problem is something else, or if we're good to merge.

jocmom commented 6 years ago

I think we should merge it now and later fix it there if required.