search

lucavandro / CodiceFiscaleJS

CodiceFiscale.js is a utility library to compute and validate Italian Tax code (codice fiscale).
Creative Commons Attribution Share Alike 4.0 International
197 stars 77 forks source link

Export changed from named to default in latest version #14

Closed nerfologist closed 5 years ago

nerfologist commented 5 years ago

Hello, in commit 50524230e9446742ed0dde8fe060ff0a29a819de (corresponding npm package version 2.1.0) the main export of this package has changed from named to default (https://github.com/lucavandro/CodiceFiscaleJS/commit/50524230e9446742ed0dde8fe060ff0a29a819de#diff-106dbfc8c2493a2f78072d7fc761456cL4).

It use to be

import { CodiceFiscale } from 'codice-fiscale-js';

Now it is

import CodiceFiscale from 'codice-fiscale-js'

I wanted to report this as it is an easy fix but also a non-backward-compatible change and should be a new major version according to best practices, anyway it should at least be mentioned in the documentation.

HTH

lucavandro commented 5 years ago

Hello, in commit 5052423 (corresponding npm package version 2.1.0) the main export of this package has changed from named to default (5052423#diff-106dbfc8c2493a2f78072d7fc761456cL4).

It use to be

import { CodiceFiscale } from 'codice-fiscale-js';

Now it is

import CodiceFiscale from 'codice-fiscale-js'

I wanted to report this as it is an easy fix but also a non-backward-compatible change and should be a new major version according to best practices, anyway it should at least be mentioned in the documentation.

HTH

Thank you. Docs have been fixed.