search

lucc / khard

Console vcard client
https://khard.readthedocs.io/en/latest/
GNU General Public License v3.0
600 stars 65 forks source link

Add MEMBER and RELATED Properties #273

Open minch4 opened 4 years ago

minch4 commented 4 years ago

Hello =)

if anyone has time for the implementation of :

it would be nice =D

lucc commented 4 years ago

I am open to pull request.

dinojr commented 3 years ago

As noted in this vdirsyncer issue, the combination google contacts + vdirsyncer doesn't properly handle these fields and creates item1.X-ABRELATEDNAMES and matching item1.X-ABLabel field but khard item1.X-ABRELATEDNAMES:name_of_the_child or khard name_of_the_child doesn't find the contact.

d7415 commented 3 years ago

google contacts + vdirsyncer doesn't properly handle these fields and creates item1.X-ABRELATEDNAMES and matching item1.X-ABLabel field

Google seems to do this their end - if you do a Takeout as VCF it will use this form.

but khard item1.X-ABRELATEDNAMES:name_of_the_child or khard name_of_the_child doesn't find the contact.

khard name_of_the_child should list the contact - my khard does. khard show name_of_the_child should show the full contact. What version of khard are you using?

dinojr commented 3 years ago

khard name_of_the_child should list the contact - my khard does. khard show name_of_the_child should show the full contact. What version of khard are you using

I tried with the v0.17.0. from Ubuntu and Khard version 0.17.1.dev47+g57b5bbc from git, still not showing with python -m khard name_of_the_child. The card of the mother (with the item.X-AB*** field in it) is found when looking for her name, and some other cards bearing the same name as the child looked for are found by khard name_of_the_child though. I tried changing the child name name in the vcf file to something unique among my vcards but it wasn't found either.

d7415 commented 3 years ago

Ok. I just checked again with 57b5bbc (I was a little behind) and I'm still getting correct results. I've tried with several of my contacts with item1.X-ABRELATEDNAMES style fields and all are working fine.

Does yours work with this minimal VCARD?

BEGIN:VCARD
VERSION:3.0
UID:bgd94fikayue7f0yn88fk9d4w1v3sxuov17m
FN:John Smith
N:Smith;John;;;
REV:20210219T111150Z
item1.X-ABLABEL:Child
item1.X-ABRELATEDNAMES:Jenny
END:VCARD

Edit: This should probably be broken out into its own issue as it's now a bug report unrelated to the initial feature request.

dinojr commented 3 years ago

With your example vcf file, Khard 0.17.1.dev47+g57b5bbc, picks up john smith but not jenny. I'll open a different issue.