search

lucc / khard

Console vcard client
https://khard.readthedocs.io/en/latest/
GNU General Public License v3.0
595 stars 66 forks source link

Prevent empty address fields to cause empty lines #296

Closed sciurius closed 3 years ago

sciurius commented 3 years ago

When formatting the postal address, empty fields cause empty lines and sometimes weird appearance. For example:

Address
    HOME: 
        Main street 20

        1234 AB Blaricum
        , Netherlands

This PR removes empty fields from the address structure so they do not cause misbehaviour.

After the patch:

Address
    HOME: 
        Main street 20
        1234 AB Blaricum
        Netherlands
sciurius commented 3 years ago

Sorry, wrong branch.

lucc commented 3 years ago

You can force push to your branches on github and that updates the PR. You can also edit some things when you edit your original post (don't know if you can change the source branch but I think the target branch can be changed).

Just for your convenience next time.