lucc / khard

Console vcard client
https://khard.readthedocs.io/en/latest/
GNU General Public License v3.0
595 stars 66 forks source link

`test_email_bug_251_part_3` regression #311

Closed afh closed 2 years ago

afh commented 2 years ago

It seems that 0c2e2bd880ac41bf5132ef665cfc343e05e1b308 may have introduced a regression failing test_email_bug_251_part_3.

/cc @scheibler

details of test run ``` python3 setup.py test -s test.test_command_line_interface.ListingCommands2.test_email_bug_251_part_3 /nix/store/spjmnyh7rh2ykh6rvarxv54qqnd8sibx-python3.9-setuptools-61.2.0/lib/python3.9/site-packages/setuptools/installer.py:27: SetuptoolsDeprecationWarning: setuptools.installer is deprecated. Requirements should be satisfied by a PEP 517 installer. warnings.warn( running test WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox. running egg_info writing khard.egg-info/PKG-INFO writing dependency_links to khard.egg-info/dependency_links.txt writing entry points to khard.egg-info/entry_points.txt writing requirements to khard.egg-info/requires.txt writing top-level names to khard.egg-info/top_level.txt reading manifest template 'MANIFEST.in' warning: no files found matching 'AUTHORS' adding license file 'LICENSE' writing manifest file 'khard.egg-info/SOURCES.txt' running build_ext test_email_bug_251_part_3 (test.test_command_line_interface.ListingCommands2) Find contacts by nickname even if a match by name exists ... FAIL ====================================================================== FAIL: test_email_bug_251_part_3 (test.test_command_line_interface.ListingCommands2) Find contacts by nickname even if a match by name exists ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/afh/Developer/khard/test/test_command_line_interface.py", line 291, in test_email_bug_251_part_3 self.assertListEqual(text, expect) AssertionError: Lists differ: ["sea[21 chars]", 'mj@example.org\tMike Jones\tpref'] != ["sea[21 chars]", 'ms@example.org\tMichael Smith\tpref', 'mj@[26 chars]ref'] First differing element 1: 'mj@example.org\tMike Jones\tpref' 'ms@example.org\tMichael Smith\tpref' Second list contains 1 additional elements. First extra element 2: 'mj@example.org\tMike Jones\tpref' - ["searching for 'mike' ...", 'mj@example.org\tMike Jones\tpref'] + ["searching for 'mike' ...", + 'ms@example.org\tMichael Smith\tpref', + 'mj@example.org\tMike Jones\tpref'] ---------------------------------------------------------------------- Ran 1 test in 0.006s FAILED (failures=1) Test failed: error: Test failed: ```
lucc commented 2 years ago

This can now also be observed in ci: https://github.com/lucc/khard/runs/7080684197?check_suite_focus=true

lucc commented 2 years ago

Eric fixed this in bb6c08a

afh commented 2 years ago

Nice! πŸ’―πŸ˜ƒπŸ‘