lucc / khard

Console vcard client
https://khard.readthedocs.io/en/latest/
GNU General Public License v3.0
595 stars 66 forks source link

[Regression] Checks fail again #315

Closed protist closed 1 year ago

protist commented 1 year ago

The latest commit 6b272e22fbedfb4a07ac594cfdaabda6b8318014 fail checks again. Again, the build itself seems to work fine.

================================================================ FAILURES =================================================================
____________________________________________ LoadingConfigFile.test_load_minimal_file_by_name _____________________________________________

self = <test.test_config.LoadingConfigFile testMethod=test_load_minimal_file_by_name>

    @mock.patch.dict('os.environ', EDITOR='editor', MERGE_EDITOR='meditor')
    def test_load_minimal_file_by_name(self):
        cfg = config.Config("test/fixture/minimal.conf")
>       self.assertEqual(cfg.editor, "editor")
E       AssertionError: ['editor'] != 'editor'

test/test_config.py:55: AssertionError
__________________________________________________ Defaults.test_editor_defaults_to_vim ___________________________________________________

self = <test.test_config.Defaults testMethod=test_editor_defaults_to_vim>

    @mock.patch.dict('os.environ', clear=True)
    def test_editor_defaults_to_vim(self):
        c = config.Config("test/fixture/minimal.conf")
>       self.assertEqual(c.editor, 'vim')
E       AssertionError: ['vim'] != 'vim'

test/test_config.py:140: AssertionError
========================================================= short test summary info =========================================================
FAILED test/test_config.py::LoadingConfigFile::test_load_minimal_file_by_name - AssertionError: ['editor'] != 'editor'
FAILED test/test_config.py::Defaults::test_editor_defaults_to_vim - AssertionError: ['vim'] != 'vim'
=========================================== 2 failed, 326 passed, 1 skipped, 1 xfailed in 0.96s ===========================================

I did a git bisect again, and one commit before this (682a0f28ead05456085a05f80658b9ca471ac840) passes okay, although both commits have 1 skipped, 1 xfailed.

test/test_command_line_interface.py::AddEmail::test_contact_is_found_if_name_matches SKIPPED (unexpected read from stdin blocks ...) [ 31%]
...
test/test_query.py::TestFieldQuery::test_empty_field_values_match_if_the_field_is_present XFAIL                                      [ 68%]
lucc commented 1 year ago

@protist thanks for the report, it is fixed now.