Closed lucc closed 1 year ago
@lemmerk can you confirm that this fixes your issue?
@skowalak do you know why you only returned the first address with 9ab66ac? It looks the original code handles lists of addresses under one label:
But the new code only picks the first list:
I could not find any discussion about this in #302 even though I made an unrelated comment about this piece of code https://github.com/lucc/khard/pull/302#discussion_r815494364 I must have missed this issue back then.
not sure how to check. followed the instructions in the dev section (i think) but it wouldn't run due to a missing version.py.
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/home/lemmerk/sandbox/khard/khard/__main__.py", line 3, in <module>
from .khard import main
File "/home/lemmerk/sandbox/khard/khard/khard.py", line 21, in <module>
from . import cli
File "/home/lemmerk/sandbox/khard/khard/cli.py", line 12, in <module>
from .version import version as khard_version
ModuleNotFoundError: No module named 'khard.version'
@lucc You are right, my code apparently only picks the first address in the list. I cannot remember why this was introduced by me, thank you for fixing it!
@lemmerk I suggest you enter a venv and then install with pip. I have to rewrite these notes some time but currently I am using nix flakes.
This fixes #323.