search

luccaPossamai / optical

MIT License
7 stars 3 forks source link

Beams passing through closed trapdoors #9

Closed DaPuffer closed 2 months ago

DaPuffer commented 5 months ago

Pretty much the opposite of issue #8 image

Frosticle commented 5 months ago

Most likely happens to doors as well

DaPuffer commented 5 months ago

image

DaPuffer commented 5 months ago

image the lazor beam might be racist.

DaPuffer commented 5 months ago

image image it also does not pass through vertical slabs from quark. depression

luccaPossamai commented 5 months ago

The problem is that there are certain blocks that cannot be generalized in terms of whether or not the laser can pass through. Think about the trapdoors and normal doors, depending on the direction of the block and the state(open/closed) the beam might pass or be blocked. Unfortunately with this blocks the tag generalization it's not the right way to represent the sense of reality. If I handle this doors problem, I gotta handle with the all other ones I decide to not let beam pass(like fence gates and such). Fixing all the specific blocks states and gotta map theses conditions to the beam is a job that will give anyone a headache.

luccaPossamai commented 5 months ago

For these blocks like moss carpet and iron trapdoors, thats an easy fix. I think that the tags like minecraft:carpets and minecraft:trapdoors for some rease don't apply for these blocks.

luccaPossamai commented 5 months ago

For other mods, the easy way to see this compatibility thing is verify if the mod blocks have the tag create_optical:beam_can_pass_through, or adding them manually.