luccahuguet / yazelix

zellij, yazi and nushell adding a File Tree to Helix & helix-friendly keybindigs for zellij
Apache License 2.0
214 stars 11 forks source link

Remapped keybindings lost when attaching #40

Closed ShaitanLyss closed 2 days ago

ShaitanLyss commented 6 days ago

I use gnome terminal and zsh. Yazelix works as intended when creating sessions, but when attaching to them it goes back to default bindings. The weird part is that the ui still shows the new bindings.

ShaitanLyss commented 6 days ago

Ressurecting also works weirdly

luccahuguet commented 5 days ago

hi there, thank you!

it seems that the odd behavior comes from the live config reload from zellij's newest version

we'll have to investigate about this..

luccahuguet commented 5 days ago

I think this commit will fix this: https://github.com/Tomcat-42/zellij/commit/b099718acbc986a27ac148379a07b979061ba599

for now I don't think there is much to be done

should the weird behavior continue in the future, what I could do is move the keybinding remaps straight to zellijs config, instead of living inside the layout

luccahuguet commented 3 days ago

@ShaitanLyss can you try the v5 branch?

it is working for me now

ShaitanLyss commented 2 days ago

Hey, it seems to be working! Thanks

luccahuguet commented 2 days ago

amazing!, im closing this now

and I will merge v5 into main when I have time

luccahuguet commented 2 days ago

thank for your help