lucee / extension-redis

Lucee Redis Cache Extension
10 stars 13 forks source link

support synchronous `put` operation #15

Closed davidAtInleague closed 1 year ago

davidAtInleague commented 1 year ago

To fix #13, this enables a "synchronous" mode for the put operation. A configuration can now look like:

this.cache.connections[ "x" ] = {
    class : 'lucee.extension.io.cache.redis.simple.RedisCache',
    bundleName : 'redis.extension',
    bundleVersion : '3.0.0.<x>',
    storage : true,
    custom : {
        "password" : "",
        "port" : "1234",
        ...
        "synchronousPut": true,
    }
};

Very high confidence this fixes the reported race condition, but I haven't done any performance regression testing to see how this pans out in the real world. However, the new option is entirely opt-in, so any regressions would be new behavior that people have to sign up for via configuration.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

davidAtInleague commented 1 year ago

closed in favor of #16