search

lucee / lucee-dockerfiles

Official Lucee Dockerfiles for Docker Hub build images
https://hub.docker.com/u/lucee/
MIT License
85 stars 50 forks source link

make prewarm more reliable #45

Closed jamiejackson closed 6 years ago

jamiejackson commented 6 years ago

You could run this build 99 times successfully, but on the 100th time, you could run into a missing deploy directory (seems to be the very last thing that's created during warmup). That causes problems for extension installations down the line.

The check for the deploy directory makes the build more reliable.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

justincarter commented 6 years ago

Thanks for the PR Jamie :) I gave this a quick test locally and it looks good. Did it fully solve your issues with extension installations, or are there other related issues with images that use this as a base? I thought I saw you mention some other problem on the forum so just wanted to check if they were related to this or not. I'm happy to merge this if you give the thumbs up!

jamiejackson commented 6 years ago

Yes, this tweak has yielded consistent builds over many runs. (I build my own due to this.)

The few official images that I've used haven't had the flaw, FWIW.

Extension installations are a chore to reliably automate, but that's more of a Lucee flaw.