lucee / lucee-dockerfiles

Official Lucee Dockerfiles for Docker Hub build images
https://hub.docker.com/u/lucee/
MIT License
85 stars 50 forks source link

Fix error message in multi-host configuratiion #67

Open r4nd0m opened 3 years ago

r4nd0m commented 3 years ago

When the tomcat is configured for multiple hosts, the following message is being displayed on startup: "static path [/opt/lucee/web/] for servlet init param [lucee-web-directory] is not allowed. Path must use a web context specific placeholder" Tha cause is a hardcoded lucee-web-directory.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

justincarter commented 3 years ago

I think this would affect all existing web context paths (e.g. /opt/lucee/web/logs would become /opt/lucee/web/{web-context-label}/logs) so some users volume mappings could fail. We might need to solve this a slightly different way so that use cases for existing paths aren't impacted.

On Sat, 28 Nov 2020, 8:46 am cinco, notifications@github.com wrote:

@cinco approved this pull request.

Thats ok, for me

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lucee/lucee-dockerfiles/pull/67#pullrequestreview-540198247, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACVQDPHMB6RDOJG4DBWDNTSSAM4NANCNFSM4S23B7VQ .

r4nd0m commented 3 years ago

I think this would affect all existing web context paths (e.g. /opt/lucee/web/logs would become /opt/lucee/web/{web-context-label}/logs) so some users volume mappings could fail. We might need to solve this a slightly different way so that use cases for existing paths aren't impacted.

Good point @justincarter, how about adding: <labels><label id="some_id_hash" name="./"/></labels> to the /opt/lucee/server/lucee-server/context/lucee-server.xml so we have a default label whose path will be resolved to the /opt/lucee/web/ in case we have only one context?

I tested it in my single-context container by renaming the label (without changing the path to the config file, it has been changed automatically) and it looks like that worked image