lucendio / reflowd_thesis

Master's Thesis: ReFlowd
Other
2 stars 2 forks source link

[250] Minor rephrasing and failure correction. #36

Closed 0ndorio closed 7 years ago

0ndorio commented 7 years ago

review phase: 3 level: mistake || enhancement || opinion type: content || phrasing || grammar or spelling || design or layout

What is wrong?

[MUST]

How should it be?d

[MUST]

Resources (links)

[MAY]

References (issues, PRs)

[MAY]

lucendio commented 7 years ago

partialy applied. one question though. what part(s) of the current (see latest version) explainantion, of asym crypto is wrong. I mean, depending on which key is used to encrypt, only the other one can be decryp the cipher. it just depends which is used for what. or am I wrong?

0ndorio commented 7 years ago

Your mistake here is the assumption that this choice is always possible. In some algorithms its settled which key is the public and which key is the private one. Two short examples:

(1) In DSA (https://en.wikipedia.org/wiki/Digital_Signature_Algorithm) the range for valid secret keys is much smaller then the range of valid public keys:

(2) In elliptic curve related algorithms the typical secret key is a single scalar value and the public key is a somehow related point on the curve you choose.

lucendio commented 7 years ago

I am sorry, a reworked version was pushed just now (https://github.com/lucendio/pdaas_thesis/commit/fd66afc4af1173d0e4a8218596b9d5a40e3e7981), not earlier as referred to in my last comment. so maybe you could have another look into the changes, aspecially the ones concerning asym crypto. maybe this relaxes the restrictions you mentioned.

lucendio commented 7 years ago

addressed in https://github.com/lucendio/pdaas_thesis/commit/872b6c50e1d3a1175369bc7850f435adef5f140f