search

luceneplusplus / LucenePlusPlus

Lucene++ is an up to date C++ port of the popular Java Lucene library, a high-performance, full-featured text search engine.
luceneplusplus@googlegroups.com
Other
738 stars 232 forks source link

Tests failing on macOS #182

Open dishti opened 2 years ago

dishti commented 2 years ago

Hi! I'm trying to run Lucene++ on macOS Catalina. A large number of tests seem to be failing on mac (>100).

Screenshot 2021-12-07 at 2 45 08 AM

Some of them appear to be due to refCount issues:

Screenshot 2021-12-07 at 1 54 58 PM

And few of them due to exceptions not being caught correctly. Are there any other settings that need to be set to be able to run the tests successfully on mac?

kmatheussen commented 2 years ago

I've actually forgot to run the tests. But now I did, and there's a lot of tsan hits, even after I fixed most (perhaps all) race conditions in conjunction with initialization of static variables (see #181).

dishti commented 2 years ago

Are these tsan hits different from the ones that you've submitted fixes for?

kmatheussen commented 2 years ago

I'm not sure. Some tsan hits might have been fixed by #183, but not all. All of the hits provided in #184 are run with the fixes in #183, so they are separate problems.

kmatheussen commented 2 years ago

But you might want to apply the patch in #183. Maybe that's enough to pass the tests, I don't know.

dishti commented 2 years ago

This patch doesn't seem to fix the test failures

barracuda156 commented 8 months ago

3.0.8 passes all tests on 10.6 PowerPC. But fails to build on 14.2, ironically.