Practicing with new issue: composition axis

lucerojimenez / gpec2010

Automatically exported from code.google.com/p/gpec2010

0 stars 0 forks source link

Practicing with new issue: composition axis #3

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. Any EOS
2. Any binary system (ex. Propane + n-Pentane)
3. Any plot considering composition as one of the axes.

Only this: 
The composition axis should be named "______ molar fraction", using the name 
for compound 1
for example, "Propane molar fraction"

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by martin.c...@gmail.com on 4 Oct 2010 at 10:32

GoogleCodeExporter commented 8 years ago

Original comment by gaitan@gmail.com on 4 Oct 2010 at 11:20

Added labels: Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 8 years ago

implemented in #r146

Original comment by gaitan@gmail.com on 8 Oct 2010 at 3:16

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

fixed

Original comment by gaitan@gmail.com on 8 Oct 2010 at 3:17

GoogleCodeExporter commented 8 years ago

this bugfix affects making Custom Plots when and axis of both plot is 
"composition" but the system is not the same. This is because MakeCustomPlot 
method just check for the label of the axis instead of the unit or a more 
general descriptor. 

Issue reopen

Original comment by gaitan@gmail.com on 8 Oct 2010 at 6:53

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

check for the last part of each label.

Original comment by gaitan@gmail.com on 11 Oct 2010 at 4:33

Changed state: Fixed