search

luceroweb / haunted-house-game

https://luceroweb.github.io/haunted-house-game/
1 stars 12 forks source link

Audio overlaps when leaving "Game Over" page when going into any other page. #109

Open ghost opened 2 years ago

ghost commented 2 years ago

Device name: JHWork Laptop

Desktop OS: Linux Ubuntu 20.04.01 64bit Browsers: Chrome/Firefox Device: Ipad 6th gen. IOS: 14.8

Description: Audio overlaps when leaving "Game Over" page when going into any other page.

Expected Behavior: Audio should end when user leaves the "Game Over" page.

Actual Behavior: Audio continuing from Game Over page into New page.

Steps to reproduce issue: 1.Goto website 2.Click into Game 3.Pick a room 4.Choose an answer the ends the game. 5.Observe audio on Game Over page carries over into new link for Restart Game

Notes: Audio of "Game Over" commandeers all other pages. Even if you open into a new room which has its own audio sound "creaking door", the "Game Over" Audio\Laugh dominates.

luceroweb commented 2 years ago

@alberme is our code engineering editor. Albert, can the "Game Over" audio be cut when you leave that page?

cc @jennah559 @lreyes-qae

alberme commented 2 years ago

@luceroweb yes it can and should be easy to fix!

alberme commented 2 years ago

@jennah559 Issue has been fixed, game over audio should now end after clicking "Restart Game". I will comment again when it is pushed to production so you can test.

ghost commented 2 years ago

Hi Albert,

Sounds good.

Thank You,

Jennifer Hughes (She/Her) QA Apprentice | Bitwise Industries @.*** | bitwiseindustries.com/ https://bitwiseindustries.com 700 Van Ness Avenue, Fresno, CA 93721 Stay up-to-date on everything Bitwise https://bitwiseindustries.com/everything-bitwise/

On Thu, Oct 28, 2021 at 4:46 PM Albert Martinez @.***> wrote:

@jennah559 https://github.com/jennah559 Issue has been fixed, game over audio should now end after clicking "Restart Game". I will comment again when it is pushed to production so you can test.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/luceroweb/haunted-house-game/issues/109#issuecomment-954302933, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWFUOQ7BTGEFKRVZNZRWKTDUJHOE7ANCNFSM5G3OLYPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

luceroweb commented 2 years ago

@jennah559 we deployed to production late yesterday, so it is safe to retest if you have a moment. cc @alberme @lreyes-qae

ghost commented 2 years ago

Hi Albert,

I notice it is still transferring into the other screens after you start the game over. Does the OS make a difference? I am on a Linux Chrome and Firefox browser.

Thank You,

Jennifer Hughes (She/Her) QA Apprentice | Bitwise Industries @.*** | bitwiseindustries.com/ https://bitwiseindustries.com 700 Van Ness Avenue, Fresno, CA 93721 Stay up-to-date on everything Bitwise https://bitwiseindustries.com/everything-bitwise/

On Fri, Oct 29, 2021 at 8:43 AM luceroweb @.***> wrote:

@jennah559 https://github.com/jennah559 we deployed to production late yesterday, so it is safe to retest if you have a moment. cc @alberme https://github.com/alberme @lreyes-qae https://github.com/lreyes-qae

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/luceroweb/haunted-house-game/issues/109#issuecomment-954844884, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWFUOQYAB4QO6PRQ7B475P3UJK6K3ANCNFSM5G3OLYPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

alberme commented 2 years ago

@jennah559 @luceroweb I noticed my changes were not pushed up to production yet, possibly just did not get merged in with the production code base. We will fix and redeploy soon.

cc @lreyes-qae

alberme commented 2 years ago

@jennah559 we just redeployed to production and is working on my end now! Please retest to confirm

cc @luceroweb @lreyes-qae