search

luceroweb / haunted-house-game

https://luceroweb.github.io/haunted-house-game/
1 stars 12 forks source link

Grammar on hallway text #92

Open VictoriaLemons opened 2 years ago

VictoriaLemons commented 2 years ago

Devices

Device name DESKTOP-VRJKTUH Processor AMD Ryzen 7 3700X 8-Core Processor 3.59 GHz System type 64-bit operating system, x64-based processor

Windows 10 Home 21H1

Google Chrome - Version 93.0.4577.63 (Official Build) (64-bit)

Expected Behavior

commas within quotations before asides, before quotes; spacing between words; no capital letters within sentences

Actual Behavior

Hallway page 2/5 needs a space and comma 3/5 commas missing 5/5 needs commas and decapitalization

Steps to Reproduce Issue

  1. Go to site
  2. click continue until Hallway page 2, 3 and 5

Screenshots

Notes

  1. quoting a complete sentence requires the capitalization even in the middle of the sentence, however, splitting the quote does not capitalize the second half.
  2. commas introducing a quote as well as comma to split the quote Spaces make intuitive sense
luceroweb commented 2 years ago

@VictoriaLemons I believe the hallway grammar issue has been addressed. @ProjectErostribe please provide Victoria with a description of what was changed so she can confirm and we can close this issue. cc @lreyes-qae

VictoriaLemons commented 2 years ago

@luceroweb I retested these hallway pages and page 3 has been addressed. I added screenshots below to aid further. Thank you!

image This marked area on page 2 requires either a period or comma, dealers choice really

image These marked areas on page 5 indicate missing commas and the decapitalization still needed.