search

luceroweb / haunted-house-game

https://luceroweb.github.io/haunted-house-game/
1 stars 12 forks source link

Game title moves to bottom of screen on "Win" screen #97

Closed rlynchjr closed 2 years ago

rlynchjr commented 2 years ago

Devices

Device name - MacBook Pro (Retina, 15-inch, Early 2013) Processor 2.7 GHz Quad-Core Intel Core i7 System type 64-bit operating system, x64-based processorGoogle Chrome Version 95.0.4638.54 (Official Build) (x86_64)

Description

Game title appears at the bottom of the screen when you successful beat the game but appears at the top of the screen on the home screen.

Expected Behavior

Game title should stay at the top of the screen to be consistent with rest of the game

Actual Behavior

After you correctly present the silver key, the title of the game appears at the very bottom of the screen below all text.

Steps to Reproduce Issue

Be as detailed as possible when writing issues so that the developer can understand exactly how you found that issue and what they need to do to recreate it without further assistance.

  1. Open website
  2. Search rooms until you receive the silver key
  3. Navigate back to hallway
  4. Click Present Key

Screenshots

Screen Shot 2021-10-27 at 11 32 52 AM Screen Shot 2021-10-27 at 11 32 56 AM Screen Shot 2021-10-27 at 11 33 00 AM

Notes

Immediately restarting a game after winning a game makes the title "bounce" from bottom to top, which may negatively impact users thoughts on the game

luceroweb commented 2 years ago

@ProjectErostribe and @SmiJa are the design leads for the Haunted House Game. How do you two feel about moving the Game Header to the top of the Game Won page in order to prevent the "bounce" from the bottom to the top of the page when you click "Restart Game"? cc @rlynchjr @lreyes-qae

ProjectErostribe commented 2 years ago

We all decided we'll do this since originally the only purpose of it being on the bottom was so that there was a visible difference from the startGame.js page.

SmiJa commented 2 years ago

@rlynchjr the header has now been moved to the top of the page.

cc @lreyes-qae @luceroweb @ProjectErostribe

rlynchjr commented 2 years ago

@SmiJa I saw the revision and it looks great! I believe this issue can be closed now.

cc @lreyes-qae @luceroweb @ProjectErostribe