search

luci / gae

A Google AppEngine SDK wrapper
61 stars 16 forks source link

Add bounded __namespace__ query support. #49

Open danjacques opened 8 years ago

danjacques commented 8 years ago

This is a valid GQL query: SELECT __key__ FROM __namespace__ WHERE __key__ > KEY(__namespace__, "foo")

Currently, bounded __namespace__ queries will not work. There are two underlying problems, one global and one specifically applying to impl/memory.

Globally, FinalizedQuery.Valid disallows special kind keys when validating inequality filters, so this query cannot be validated.

Additionally, in impl/memory, inequality filters aren't applied to namespace queries.

riannucci commented 8 years ago

Hm I thought I did start/end in impl/memory, but I guess not

On Sat, Apr 23, 2016, 17:02 Daniel Jacques notifications@github.com wrote:

This is a valid GQL query: SELECT key FROM namespace WHERE key > KEY(namespace, "foo")

Currently, bounded namespace queries will not work. There are two underlying problems, one global and one specifically applying to impl/memory.

Globally, FinalizedQuery.Valid https://github.com/luci/gae/blob/76382c0/service/datastore/finalized_query.go#L331 disallows special (...) kind keys when validating inequality filters, so this query cannot be validated.

Additionally, in impl/memory, inequality filters aren't applied to namespace queries.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/luci/gae/issues/49