search

lucia-auth / lucia

Authentication, simple and clean
https://lucia-auth.com
MIT License
8.35k stars 448 forks source link

chore(adapter-drizzle): mark drizzle-orm as a peer dependency #1556

Closed ryanleecode closed 2 months ago

ryanleecode commented 2 months ago

Mark drizzle-orm as a peer dep so you don't get type issues when using the adapters that have different versions of drizzle-orm specified.

pilcrowOnPaper commented 2 months ago

While drizzle is still in beta, we should probably set the version to 0.29

ryanleecode commented 2 months ago

I think we need to be more permissive. For example in 0.30, the drizzle team released major fixes for the AWS Data API and data API was unusuable before 0.30.

https://github.com/drizzle-team/drizzle-orm/releases/tag/0.30.8

Locking it to 0.29 would be unfair. We could also do something like >= 0.29 < 1

pilcrowOnPaper commented 2 months ago

Oh didn't realize there's a new version. Agree that your idea is better since I doubt they introduce breaking changes to the core API

pilcrowOnPaper commented 2 months ago

Thanks!