lucia-auth / lucia

Authentication, simple and clean
https://lucia-auth.com
MIT License
9.16k stars 464 forks source link

[Docs]: should recommend using adapter-kysely with Prisma/Atlas/DizzleORM for schemas/migrations. #495

Closed igalklebanov closed 1 year ago

igalklebanov commented 1 year ago

Description

Hey 👋

Great library! 🥇 and thanks for adapter-kysely!

I think the docs should mention you can use kysely for data access & manage schemas/migrations with:

I'd be happy to help with this effort!

pilcrowOnPaper commented 1 year ago

Thanks for creating Kysely!

I'm guessing this would mean updating the database types section?

https://lucia-auth.com/database/kysely#database-types

igalklebanov commented 1 year ago

Thanks for creating Kysely!

All credit goes to @koskimas. 😄

I'm guessing this would mean updating the database types section?

lucia-auth.com/database/kysely#database-types

Hmm, I think database structure section? Add a Prisma block over/under the postgresql/mysql/sqlite blocks with a link to the Prisma adapter's models.

Also maybe add a note in Prisma page that you can use Kysely adapter instead. "This is better in serverless/edge environments yadda yadda".

WDYT?

pilcrowOnPaper commented 1 year ago

Add a Prisma block over/under the postgresql/mysql/sqlite blocks with a link to the Prisma adapter's models.

That sounds good to me

Also maybe add a note in Prisma page that you can use Kysely adapter instead. "This is better in serverless/edge environments yadda yadda".

We're just giving people options and not giving out recommendations so I don't feel comfortable doing that. I have personal preferences, but having that affect the content is unprofessional, at least to me.

igalklebanov commented 1 year ago

We're just giving people options and not giving out recommendations so I don't feel comfortable doing that. I have personal preferences, but having that affect the content is unprofessional, at least to me.

My bad, was just voicing the current trends. You're right.

pilcrowOnPaper commented 1 year ago

Closing this since the main issue was already resolved and I'm not sure where to mention those features.