search

lucianmachado / sails-oracle-database

Oracle Database adapter for Sails.js
MIT License
2 stars 7 forks source link

Waterline-Sequel 0.5.0 dependency #4

Closed cope closed 7 years ago

cope commented 7 years ago

Hey @lucianmachado,

Can we remove the waterline-sequel 0.5.0 from the dependencies and use the latest version of it?

We have submitted a fix that is supposed to go into the 0.6.5 and with this hard dependency on 0.5.0, our fix will not be available.

lucianmachado commented 7 years ago

Hey @cope,

I think isn't a good idea to use the latest version of waterline-sequel because we need these PR's: #17, #67.

I noticed that the waterline-sequel is going to be replaced for waterline-sql-builder, so I think the best approach is migrate to waterline-sql-builder instead waterline-sequel...

cope commented 7 years ago

Ok, so then I will submit my waterline-sequel PR to your fork and then see what happens with waterline-sql-builder down the line...

Is that OK?

cope commented 7 years ago

Hi @lucianmachado,

I created the pull request for your fork of waterline-sequel: https://github.com/lucianmachado/waterline-sequel/pull/1

Please take a look and approve if it is OK :)

lucianmachado commented 7 years ago

@cope I'll check asap, thanks!